Michal Skrivanek has posted comments on this change.

Change subject: agent: Added APT package list support (BZ#838632)
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

please don't ignore comments from patchset 1;-)

....................................................
File ovirt-guest-agent/ovirt-guest-agent.conf
Line 7: heart_beat_rate = 5
Line 8: report_user_rate = 10
Line 9: report_application_rate = 120
Line 10: report_disk_usage = 300
Line 11: applications_list = kernel ovirt-guest-agent xorg-x11-drv-qxl 
linux-image xserver-xorg-video-qxl
please add a corresponding comment here. It's mixed up and while it's not worth 
splitting it at config level it's still worth a note imho
Line 12: ignored_fs = rootfs tmpfs autofs cgroup selinuxfs udev mqueue nfsd 
proc sysfs devtmpfs hugetlbfs rpc_pipefs devpts securityfs debugfs binfmt_misc
Line 13: 
Line 14: [virtio]
Line 15: 


--
To view, visit http://gerrit.ovirt.org/8642
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to