Vinzenz Feenstra has posted comments on this change.

Change subject: agent: Added APT package list support (BZ#838632)
......................................................................


Patch Set 4: (3 inline comments)

....................................................
File ovirt-guest-agent/GuestAgentLinux2.py
Line 60:             apps += self.rpm_list_packages(app_list)
Line 61:         if self.apt_pkg:
Line 62:             apps += self.apt_list_packages(app_list)
Line 63:         # Make the items in the list unique
Line 64:         apps = list(set(apps))
Done
Line 65:         logging.debug("PkgMgr: list_pkgs returns %s" % (str(apps)))
Line 66:         return apps
Line 67: 
Line 68:     def __init__(self):


Line 70:         self.apt_pkg = None
Line 71:         try:
Line 72:             import rpm
Line 73:             self.rpm = rpm
Line 74:         except ImportError:            
Done
Line 75:             pass
Line 76: 
Line 77:         try:
Line 78:             from apt import apt_pkg


Line 77:         try:
Line 78:             from apt import apt_pkg
Line 79:             apt_pkg.init()
Line 80:             self.apt_pkg = apt_pkg
Line 81:         except ImportError:
Done
Line 82:             pass
Line 83: 
Line 84: class NicMgr(object):
Line 85: 


--
To view, visit http://gerrit.ovirt.org/8642
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to