Itamar Heim has posted comments on this change. Change subject: core: adding engine Maintenance and Prepare mode.(#868639) ......................................................................
Patch Set 4: i don't like black listing in general. for the queries, since the default is all should be available, i think the default of black listing is fine. for actions though, since we want to enable only a few actions, i think white listing makes more sense. i.e., we should be annotating for the exceptions, or, always for white listing -- To view, visit http://gerrit.ovirt.org/8669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches