Maor Lipchuk has posted comments on this change. Change subject: core: introduce LibvirtSecretValidator ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/41554/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretValidator.java: Line 13: private final LibvirtSecret libvirtSecret; Line 14: private final ProviderDao providerDao; Line 15: private final LibvirtSecretDao libvirtSecretDao; Line 16: Line 17: public LibvirtSecretValidator(LibvirtSecret libvirtSecret, DbFacade dbFacade) { Why dbFacade is passed as an argument? Why not use it the same as we do in other validators Line 18: this.libvirtSecret = libvirtSecret; Line 19: this.providerDao = dbFacade.getProviderDao(); Line 20: this.libvirtSecretDao = dbFacade.getLibvirtSecretDao(); Line 21: } -- To view, visit https://gerrit.ovirt.org/41554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d80f1b1966b90f4f8c9edb4b5ee37ead513d3a5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
