Daniel Erez has posted comments on this change. Change subject: core: introduce LibvirtSecretValidator ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/41554/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/LibvirtSecretValidator.java: Line 13: private final LibvirtSecret libvirtSecret; Line 14: private final ProviderDao providerDao; Line 15: private final LibvirtSecretDao libvirtSecretDao; Line 16: Line 17: public LibvirtSecretValidator(LibvirtSecret libvirtSecret, DbFacade dbFacade) { > Why dbFacade is passed as an argument? I'll use injections instead. Line 18: this.libvirtSecret = libvirtSecret; Line 19: this.providerDao = dbFacade.getProviderDao(); Line 20: this.libvirtSecretDao = dbFacade.getLibvirtSecretDao(); Line 21: } https://gerrit.ovirt.org/#/c/41554/5/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1422: ERROR_CANNOT_DETACH_CINDER_PROVIDER_WITH_IMAGES=Cannot detach a non empty Cinder provider.\n\ Line 1423: -Please remove all VMs / Templates / Disks and try again. Line 1424: LIBVIRT_SECRET_UUID_CANNOT_BE_EMPTY=Cannot ${action} ${type}. Authentication Key UUID cannot be empty. Line 1425: LIBVIRT_SECRET_VALUE_CANNOT_BE_EMPTY=Cannot ${action} ${type}. Authentication Key value cannot be empty. Line 1426: LIBVIRT_SECRET_VALUE_ILLEGAL_FORMATCannot ${action} ${type}. Authentication Key value should be encoded in Base64. > you forgot equals here Done Line 1427: LIBVIRT_SECRET_UUID_ALREADY_EXISTS=Cannot ${action} ${type}. Authentication Key UUID already exists. Line 1428: LIBVIRT_SECRET_UUID_NOT_EXISTS=Cannot ${action} ${type}. Authentication Key UUID does not exists. Line 1429: Line 1430: NO_HOST_PROVIDER_FOR_SYSTEM=The engine server is not associated with any host provider. https://gerrit.ovirt.org/#/c/41554/5/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1367: ERROR_CANNOT_DETACH_CINDER_PROVIDER_WITH_IMAGES=Cannot detach a non empty Cinder provider.\n\ Line 1368: -Please remove all VMs / Templates / Disks and try again. Line 1369: LIBVIRT_SECRET_UUID_CANNOT_BE_EMPTY=Cannot ${action} ${type}. Authentication Key UUID cannot be empty. Line 1370: LIBVIRT_SECRET_VALUE_CANNOT_BE_EMPTY=Cannot ${action} ${type}. Authentication Key value cannot be empty. Line 1371: LIBVIRT_SECRET_VALUE_ILLEGAL_FORMATCannot ${action} ${type}. Authentication Key value should be encoded in Base64. > equals? Done Line 1372: LIBVIRT_SECRET_UUID_ALREADY_EXISTS=Cannot ${action} ${type}. Authentication Key UUID already exists. Line 1373: LIBVIRT_SECRET_UUID_NOT_EXISTS=Cannot ${action} ${type}. Authentication Key UUID does not exists. Line 1374: Line 1375: NO_HOST_PROVIDER_FOR_SYSTEM=The engine server is not associated with any host provider. -- To view, visit https://gerrit.ovirt.org/41554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d80f1b1966b90f4f8c9edb4b5ee37ead513d3a5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
