Deepak C Shetty has posted comments on this change.
Change subject: core: WIP: Update StoragePoolValidator test to test GlusterFS.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 198: returnValue =
validator.isPosixDcAndMatchingCompatiblityVersion();
Line 199: }
Line 200: if (returnValue) {
Line 201: returnValue =
validator.isGlusterDcAndMatchingCompatiblityVersion();
Line 202: }
IIUC, the isPosixDc... check is done provided its not LocalFs. Since you are
extending the logic, you should either say if(!returnValue) and do the
isGlusterDc.. check -- OR -- modify isPosixDc... check to isNotPosixDc.. to
retain if(returnValue) for Gluster case ?
Line 203: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
Line 204: return returnValue;
Line 205: }
Line 206:
--
To view, visit http://gerrit.ovirt.org/8836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4cd98cd06716c31248d8ec4f21a3a6f79f13102
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
