Liron Aravot has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 130: return StorageHelperDirector.getInstance()
Line 131:
.getItem(getStorageDomain().getstorage_type())
Line 132: .ConnectStorageToLunByVdsId(null,
vdss.get(0).getId(), lun, getStoragePool().getId());
Line 133: } catch (VdcBLLException e) {
Line 134: log.error(e);
will add here an proper message.
Line 135: return false;
Line 136: }
Line 137: }
Line 138: break;
--
To view, visit http://gerrit.ovirt.org/8900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa07be1fd6d6021481c8c0291458aff403304ee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
