Liron Aravot has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 128:
Line 129: try {
Line 130: return StorageHelperDirector.getInstance()
Line 131:
.getItem(getStorageDomain().getstorage_type())
Line 132: .ConnectStorageToLunByVdsId(null,
vdss.get(0).getId(), lun, getStoragePool().getId());
1. the popup window won't get stuck as this check won't happen for GUI requests
(getParameters().getValidateLunConnection() defaults to false).
2. I agree, this check purpose is to perform some sort of sanity check of the
connection information when defining the lun (look in the bug please)- but
indeed it might not work later on (it's mentioned in the bug page as well). The
needed behaviour needs to be defined (defaults to true at the moment through
rest which might be changed) but basically if the user add the luns through
specific host (this is why its WIP), he can define the vm to run on that host
and have success running it knowing that the lun connection details were
verified and that he didn't had some sort of typo or whatever during creation.
Line 133: } catch (VdcBLLException e) {
Line 134: log.error(e);
Line 135: return false;
Line 136: }
--
To view, visit http://gerrit.ovirt.org/8900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa07be1fd6d6021481c8c0291458aff403304ee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
