Allon Mureinik has posted comments on this change. Change subject: core: Dead store to tempVar in GetTagsByUserIdQuery.executeQueryCommand() ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) see minor comment inline .................................................... Commit Message Line 13: Dead store to tempVar in org.ovirt.engine.core.bll.GetTagsByUserIdQuery.executeQueryCommand() Line 14: Line 15: This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Line 16: Line 17: Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. when you rebase, can you please break up these long lines with \n's? Line 18: Line 19: Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3 -- To view, visit http://gerrit.ovirt.org/8682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
