Moti Asayag has posted comments on this change.

Change subject: core: Dead store to tempVar in 
GetTagsByUserIdQuery.executeQueryCommand()
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByUserIdQuery.java
Line 1: package org.ovirt.engine.core.bll;
Line 2: 
Line 3: import org.ovirt.engine.core.dal.dbbroker.*;
Line 4: import org.ovirt.engine.core.common.queries.*;
The ovirt formatter for eclipse should have also change the * to explicit list 
of imports.I'll re-submit on top of this patch with that change.
Line 5: 
Line 6: public class GetTagsByUserIdQuery<P extends GetTagsByUserIdParameters> 
extends
Line 7:         QueriesCommandBase<P> {
Line 8:     public GetTagsByUserIdQuery(P parameters) {


--
To view, visit http://gerrit.ovirt.org/8682
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2f021d90218f9cd7ec6bda52105d9367f41f2a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to