Moti Asayag has posted comments on this change.
Change subject: webadmin: Network Main Tab- cleanup
......................................................................
Patch Set 1: (8 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
Line 8:
Line 9: public class ClusterNetworkModel extends EntityModel {
Line 10:
Line 11: private boolean management;
Line 12: private boolean attached = true;
you can remove this initialization since in the single c'tor this class have -
the value is set to false.
Line 13: private VDSGroup cluster = null;
Line 14:
Line 15: public ClusterNetworkModel(Network network) {
Line 16: setEntity(network);
Line 14:
Line 15: public ClusterNetworkModel(Network network) {
Line 16: setEntity(network);
Line 17: if (network.getCluster() == null){
Line 18: attached = false;
please remove this initialization as the false is the default value assigned to
boolean type.
Line 19: // Init with default values
Line 20: getEntity().setCluster(new network_cluster());
Line 21: }
Line 22: if
(HostInterfaceListModel.ENGINE_NETWORK_NAME.equals(network.getname())) {
Line 66: return getEntity().isVmNetwork();
Line 67: }
Line 68:
Line 69: public void setAttached(boolean attached) {
Line 70: attached = attached;
this is self assignment - please modify to:
this.attached = attached
Line 71: }
Line 72:
Line 73: public void setDisplayNetwork(boolean displayNetwork) {
Line 74: getEntity().getCluster().setis_display(displayNetwork);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
Line 271: cancel();
Line 272: }
Line 273: }
Line 274:
Line 275: public UICommand getManageCommand()
please format this method and the one below
Line 276: {
Line 277: return manageCommand;
Line 278: }
Line 279:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java
Line 75: } else {
Line 76: setMtu(extendedNetwork.getNetwork().getMtu());
Line 77: }
Line 78: }
Line 79:
please format from here till the end of the file.
Line 80: public String getName()
Line 81: {
Line 82: return name;
Line 83: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
Line 156: protected void SelectedItemsChanged()
Line 157: {
Line 158: super.SelectedItemsChanged();
Line 159: updateActionAvailability();
Line 160: }
please apply the formatter for the code below.
Line 161:
Line 162: public UICommand getSetupNetworksCommand()
Line 163: {
Line 164: return setupNetworksCommand;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
Line 291: @Override
Line 292: protected String getListName() {
Line 293: return "NetworkListModel"; //$NON-NLS-1$
Line 294: }
Line 295:
format.
Line 296: public UICommand getNewCommand()
Line 297: {
Line 298: return newCommand;
Line 299: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java
Line 197: {
Line 198: remove();
Line 199: }
Line 200: }
Line 201:
format.
Line 202: public UICommand getRemoveCommand()
Line 203: {
Line 204: return removeCommand;
Line 205: }
--
To view, visit http://gerrit.ovirt.org/9008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
