Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network Main Tab- cleanup
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
Line 8:
Line 9: public class ClusterNetworkModel extends EntityModel {
Line 10:
Line 11: private boolean management;
Line 12: private boolean attached = true;
I don't agree- it is set to false just if (network.getCluster() == null), in
all the other case it should be true
Line 13: private VDSGroup cluster = null;
Line 14:
Line 15: public ClusterNetworkModel(Network network) {
Line 16: setEntity(network);
Line 14:
Line 15: public ClusterNetworkModel(Network network) {
Line 16: setEntity(network);
Line 17: if (network.getCluster() == null){
Line 18: attached = false;
Don't agree- see the previous comment.
Line 19: // Init with default values
Line 20: getEntity().setCluster(new network_cluster());
Line 21: }
Line 22: if
(HostInterfaceListModel.ENGINE_NETWORK_NAME.equals(network.getname())) {
Line 66: return getEntity().isVmNetwork();
Line 67: }
Line 68:
Line 69: public void setAttached(boolean attached) {
Line 70: attached = attached;
Done
Line 71: }
Line 72:
Line 73: public void setDisplayNetwork(boolean displayNetwork) {
Line 74: getEntity().getCluster().setis_display(displayNetwork);
--
To view, visit http://gerrit.ovirt.org/9008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
