Yair Zaslavsky has posted comments on this change.
Change subject: engine: Continue preporation for removing a global lock at SPM
calls
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java
Line 6: public ResetIrsVDSCommandParameters(Guid storagePoolId, Guid vdsId)
{
Line 7: super(storagePoolId);
Line 8: setVdsId(vdsId);
Line 9: }
Line 10:
Trailing whitespace, please remove.
Line 11: private Guid privateVdsId;
Line 12:
Line 13: public Guid getVdsId() {
Line 14: return privateVdsId;
--
To view, visit http://gerrit.ovirt.org/9025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5b20da89594f0fd245cfb87794c29b31273193
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
