Yair Zaslavsky has posted comments on this change. Change subject: engine: Continue preparation for removing a global lock at SPM calls ......................................................................
Patch Set 2: Looks good to me, approved Ayal, The host name is used for logging. I don't understand why we preform name equality at code for this, or how it can prevent us from races or other issues. This looks like a redundant protection code, and unfortunately existed also back to 2.2 days. -- To view, visit http://gerrit.ovirt.org/9025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa5b20da89594f0fd245cfb87794c29b31273193 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
