Liron Aravot has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 108: VdcObjectType.Storage,
Line 109: sourceDomainId,
Line 110: getParameters().getStorageDomainId()));
Line 111:
Line 112: // Add storage domain in db only if there is new entity
in DB.
please move this if to a method instead of repeating it here and in
endSuccesffuly
Line 113: if (getParameters().getOperation() != ImageOperation.Move
Line 114: && getParameters().getParentCommand() !=
VdcActionType.ImportVm
Line 115: && getParameters().getParentCommand() !=
VdcActionType.ImportVmTemplate
Line 116: && getParameters().getAddImageDomainMapping()) {
Line 176: (new
image_storage_domain_map_id(getParameters().getImageId(),
Line 177:
getParameters().getStorageDomainId()));
Line 178: }
Line 179: revertTasks();
Line 180: } else {
UnlockImage is performed anyway, so it can just be removed out of the if-else.
Line 181: unLockImage();
Line 182: }
Line 183:
Line 184: setSucceeded(true);
....................................................
Commit Message
Line 15: By doing that, the user can use the VM disks even if the move operation
Line 16: failed.
Line 17:
Line 18: As part of the fix, some of the code which updated the destination
Line 19: storage domain in the disk, moved from the execute part to the
comma unneeded
Line 20: EndWithSuccess section.
Line 21:
Line 22: Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a
Line 16: failed.
Line 17:
Line 18: As part of the fix, some of the code which updated the destination
Line 19: storage domain in the disk, moved from the execute part to the
Line 20: EndWithSuccess section.
endSuccesfully method?
Line 21:
Line 22: Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a
--
To view, visit http://gerrit.ovirt.org/9103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
