Maor Lipchuk has submitted this change and it was merged. Change subject: core: Failed move disk should not set illegal disk. ......................................................................
core: Failed move disk should not set illegal disk. When disk failed to be moved to another storage domain, the engine set the disk status to Illegal with the destination storage domain. The proposed fix, set the disk state to OK, with the original storage domain if the move task fails. By doing that, the user can use the VM disks even if the move operation failed. As part of the fix, some of the code which updated the destination storage domain in the disk, moved from the execute part to the EndSuccesfully section. Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 2 files changed, 25 insertions(+), 24 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
