Sharad Mishra has posted comments on this change.
Change subject: core: Integer reference comparison fix
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 614: fetchedBrick.getQualifiedName());
Line 615: }
Line 616: } else {
Line 617: // brick found. update it if required. Only property
that could be different is the brick order
Line 618: if
(!ObjectUtils.objectsEqual(existingBrick.getBrickOrder(),
fetchedBrick.getBrickOrder())) {
The reason for using 'objectEqual' is that you are expecting the arguments
could be null. But if they are null, then you will be trouble later with NPE.
Should we not check for null before and proceed with this 'equal' check only
for non-null values?
Line 619: log.infoFormat("Brick order for brick {0} changed
from {1} to {2} because of direct CLI operations. Updating engine DB
accordingly.",
Line 620: existingBrick.getQualifiedName(),
Line 621: existingBrick.getBrickOrder(),
Line 622: fetchedBrick.getBrickOrder());
--
To view, visit http://gerrit.ovirt.org/9104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
