Allon Mureinik has posted comments on this change. Change subject: core: Integer reference comparison fix ......................................................................
Patch Set 1: Looks good to me, but someone else must approve Laszlo - I understand the difference between reference comparison (==) and value comparison (equals). I was trying to make the point that if we aren't concerned with nulls, simply integer1.equals(interger2) would do the trick, and we won't ugly up the code with old utilities. If nulls are an issues, by all means - +1. -- To view, visit http://gerrit.ovirt.org/9104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
