Daniel Erez has posted comments on this change.
Change subject: webadmin: Messages text fixes
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 963:
Line 964: @DefaultStringValue("Invalid parameters.\n-Please check that bond
name is formatted as <bondYYY>.\n-Bond consist of at least two network
interfaces(NICs).")
Line 965: String NETWORK_BOND_PARAMETERS_INVALID();
Line 966:
Line 967: @DefaultStringValue("Network ovirtmgmt is mandatory, it cannot be
modified.")
Shouldn't ovirtmgmt be replaced with '${NetworkName}' ?
(as in .properties files)
Line 968: String NETWORK_DEFAULT_UPDATE_NAME_INVALID();
Line 969:
Line 970: @DefaultStringValue("Network Interface already belongs to the
bond.")
Line 971: String NETWORK_INTERFACE_ALREADY_IN_BOND();
Line 1188:
Line 1189: @DefaultStringValue("Cannot ${action} ${type}. Cluster ID is not
valid.")
Line 1190: String VM_CLUSTER_IS_NOT_VALID();
Line 1191:
Line 1192: @DefaultStringValue("The management Network (ovirtmgmt) is
mandatory and cannot be removed.")
same here
Line 1193: String NETWORK_CANNOT_REMOVE_MANAGEMENT_NETWORK();
Line 1194:
Line 1195: @DefaultStringValue("Previous network name is required.")
Line 1196: String NETWORK_OLD_NETWORK_NOT_SPECIFIED();
Line 1455:
Line 1456: @DefaultStringValue("Both low and high CPU utilization
thresholds must be defined when using power saving policy.")
Line 1457: String
VDS_GROUP_BOTH_LOW_AND_HIGH_CPU_UTILIZATION_PERCENTAGE_MUST_BE_DEFINED_WHEN_USING_POWER_SAVING();
Line 1458:
Line 1459: @DefaultStringValue("The default gateway should be set only on
ovirtmgmt network")
same here
Line 1460: String NETWORK_ATTACH_ILLEGAL_GATEWAY();
Line 1461:
Line 1462: @DefaultStringValue("User/group ID cannot be empty.")
Line 1463: String MISSING_DIRECTORY_ELEMENT_ID();
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6368f77f174ff17b4f78856d01236eb07bae8e2a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
