Moti Asayag has posted comments on this change.
Change subject: webadmin: Messages text fixes
......................................................................
Patch Set 3: (2 inline comments)
minor comments regarding the commit message
....................................................
Commit Message
Line 16: Network), "engine" was replaced with a placeholder for the Management
Line 17: Network name ("${NetworkName}"), which should be retreived from the
Line 18: configuration instead of being hard-coded.
Line 19:
Line 20: Also, all relevant engine command that were referring to the messages
s/command/commands
Line 21: above were change to include also a "parameter value" message (in the
Line 22: form of "$NetworkName [network-name-from-configuration]") in the
relevant
Line 23: canDoActionMessages list.
Line 24:
Line 17: Network name ("${NetworkName}"), which should be retreived from the
Line 18: configuration instead of being hard-coded.
Line 19:
Line 20: Also, all relevant engine command that were referring to the messages
Line 21: above were change to include also a "parameter value" message (in the
s/change/changed
Line 22: form of "$NetworkName [network-name-from-configuration]") in the
relevant
Line 23: canDoActionMessages list.
Line 24:
Line 25: - Internal oVirt Engine Error
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6368f77f174ff17b4f78856d01236eb07bae8e2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
