Liron Aravot has posted comments on this change.
Change subject: core: WIP: NPEs and wrong persisted information when reusing
LUNs
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
Line 93: @Override
Line 94: public void removeLun(LUNs lun) {
Line 95: if (lun.getvolume_group_id().isEmpty()) {
Line 96: DbFacade.getInstance().getLunDao().remove(lun.getLUN_id());
Line 97: }
Correct, wasn't in the if by mistake.
Line 98: for (storage_server_connections connection :
filterConnectionsUsedByOthers(lun.getLunConnections(),
Line 99: "",
Line 100: lun.getLUN_id())) {
Line 101:
DbFacade.getInstance().getStorageServerConnectionDao().remove(connection.getid());
--
To view, visit http://gerrit.ovirt.org/9229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
