Vered Volansky has posted comments on this change.
Change subject: core: WIP: NPEs and wrong persisted information when reusing
LUNs
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
Line 192:
.getStorageServerConnectionDao().getAllForVolumeGroup(storageDomain.getstorage());
Line 193: final List<LUNs> lunsList =
DbFacade.getInstance().getLunDao().getAllForVolumeGroup(storageDomain.getstorage());
Line 194: int numOfRemovedLuns = 0;
Line 195: for (LUNs lun : lunsList) {
Line 196: if
(DbFacade.getInstance().getDiskLunMapDao().getDiskIdByLunId(lun.getLUN_id()) ==
null) {
I'd extract lun.getLUN_id() to a variable.
Line 197:
DbFacade.getInstance().getLunDao().remove(lun.getLUN_id());
Line 198: numOfRemovedLuns++;
Line 199: } else {
Line 200:
DbFacade.getInstance().getLunDao().updateLUNsVolumeGroupId(lun.getLUN_id(), "");
....................................................
Commit Message
Line 4: Commit: Liron Aravot <[email protected]>
Line 5: CommitDate: 2012-11-13 19:25:41 +0200
Line 6:
Line 7: core: WIP: NPEs and wrong persisted information when reusing LUNs
Line 8:
The following sentence is not clear, please rephrase.
Line 9: Generally, the following issues caused that a created lun based storage
Line 10: domain when reusing luns led to NPEs and wrong data shown to the user
during execution of GetLunsByVgIdQuery.
Line 11:
Line 12: This patch fixes the following issues:
Line 16:
Line 17: 2. When extending a domain to use an existing lun, the domain id isn't
Line 18: set to that lun which causes to NPE in GetLunsByVgIdQuery or wrong data
Line 19: provided to the user.
Line 20:
Same as 2.
Line 21: 3. When creating a domain from an existing lun, the domain id isn't set
Line 22: to this lun which might causes to NPE in GetLunsByVgIdQuery or
Line 23: wrong data provided to the user.
Line 24:
--
To view, visit http://gerrit.ovirt.org/9229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
