Allon Mureinik has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
......................................................................
Patch Set 2:
Ayal - as long as he have these two operation in the same command with an
ImageOperation parameter, the only way out of this would be to have something
like this:
if (getImageOperation == Copy) {
return "Copying"
} else {
return "Moving"
}
which looks even worse to me.
The real way to fix it would be to break MoveOrCopy in to two commands.
--
To view, visit http://gerrit.ovirt.org/9303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
