Allon Mureinik has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
I like the previous version better, but this would do too.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 431: jobProperties.put("sourcesd", sourceSDName);
Line 432: jobProperties.put("targetsd", getStorageDomainName());
Line 433: if
(ImageOperation.Move.equals(getParameters().getOperation())) {
Line 434: jobProperties.put("action", "Moving");
Line 435: }
I'd take the else up a line
Line 436: else {
Line 437: jobProperties.put("action", "Copying");
Line 438: }
Line 439:
--
To view, visit http://gerrit.ovirt.org/9303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
