Alon Bar-Lev has uploaded a new change for review. Change subject: bootstrap: cleanup approve command ......................................................................
bootstrap: cleanup approve command Do not use parent member if there is a method to access it. Change-Id: I212c7b7ab58dd45c56c8c94d62c49a9d2236d863 Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/9452/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java index 4ce1abd..9507681 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java @@ -41,13 +41,10 @@ @Override public AuditLogType getAuditLogTypeValue() { - if (!getSucceeded()) { - if (_failureLogTypeValue == AuditLogType.VDS_INSTALL_FAILED) { - AddCustomValue("FailedInstallMessage", getErrorMessage(_failureMessage)); - } - return _failureLogTypeValue; - } else { + if (getSucceeded()) { return AuditLogType.VDS_APPROVE; + } else { + return super.getAuditLogTypeValue(); } } -- To view, visit http://gerrit.ovirt.org/9452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I212c7b7ab58dd45c56c8c94d62c49a9d2236d863 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
