Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: cleanup approve command
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java
Line 42: @Override
Line 43: public AuditLogType getAuditLogTypeValue() {
Line 44: if (getSucceeded()) {
Line 45: return AuditLogType.VDS_APPROVE;
Line 46: } else {
If the two control paths are return, I tend to leave the if-else.
Line 47: return super.getAuditLogTypeValue();
Line 48: }
Line 49: }
Line 50:
--
To view, visit http://gerrit.ovirt.org/9452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I212c7b7ab58dd45c56c8c94d62c49a9d2236d863
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
