Yair Zaslavsky has posted comments on this change. Change subject: tools: engine-config cleanup all 2.2 keys from db ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/action_version_map_sp.sql Line 61: create or replace FUNCTION fn_db_delete_version_map(v_cluster_version varchar(10), v_sp_version varchar(40)) Line 62: returns void Line 63: AS $procedure$ Line 64: BEGIN Line 65: delete from action_version_map where cluster_minimal_version = v_cluster_version and storage_pool_minimal_version = v_sp_version; Ravi, I know it's not all over our sps, but can you please use the format as in above stored procs? (capitalized letters for SQL keywords, WHERE in separate line, ...) Line 66: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/9492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fdfed4efa2c4d1f52189943fd1dd38ea0c3cbb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
