Eli Mesika has posted comments on this change.

Change subject: tools: engine-config cleanup all 2.2 keys from db
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File backend/manager/dbscripts/common_sp.sql
Line 99: END; $procedure$
Line 100: LANGUAGE plpgsql;
Line 101: 
Line 102: -- Deletes a key from vdc_options by version
Line 103: create or replace FUNCTION fn_db_delete_config_for_version(v_version 
varchar(40))
I prefer this function to get text as v_version (may be comma delimited values)
Line 104: returns void
Line 105: AS $procedure$
Line 106: BEGIN
Line 107:      delete from vdc_options where version = v_version;


Line 103: create or replace FUNCTION fn_db_delete_config_for_version(v_version 
varchar(40))
Line 104: returns void
Line 105: AS $procedure$
Line 106: BEGIN
Line 107:      delete from vdc_options where version = v_version;
select from vdc_options where version in(v_version);

This way you can call once in other patches to delete key versions
Line 108: END; $procedure$
Line 109: LANGUAGE plpgsql;
Line 110: 
Line 111: -- Deletes a key from vdc_options by name


--
To view, visit http://gerrit.ovirt.org/9492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdfed4efa2c4d1f52189943fd1dd38ea0c3cbb0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to