Einav Cohen has posted comments on this change. Change subject: core: VM cleanup ......................................................................
Patch Set 5: > In the old WPF days, we needed some compatibility, so changes such as- > isAutoStartup <= getauto_startup > were blocked. This may not be relevant anymore, but I'd appreciate if Einav > can ack it as well. [sorry for the extremely late response] The issue that we had with WPF was related to the fact that we couldn't control the way that the C#-to-Java-converter converts C# getters/setters to java methods. That let to constraints on how methods should be named on the java side. We don't have any of the above anymore; therefore, as long as all the method renames were appropriately updated also on the GUI side (just like all other parts of the code that are using the business entity) - we should be good. -- To view, visit http://gerrit.ovirt.org/9480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42da374a6929eae9be1880b6948d9218627b6c4f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
