Roy Golan has posted comments on this change.

Change subject: core: VM cleanup
......................................................................


Patch Set 6: (1 inline comment)

you have more fields to update there

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 85:                 "interfaces" // interfaces is relational entity - 
ignore value changes
Line 86:         });
Line 87:         mUpdateVmsStatic.AddFields(
Line 88:                 Arrays.asList(new Enum<?>[] { VMStatus.Down }),
Line 89:                 Arrays.asList(new String[] { "vds_group_id", 
"time_zone", "is_stateless", "nice_level", "mem_size_mb",
this needs update as well
Line 90:                         "num_of_sockets", "cpu_per_socket", 
"iso_path", "userDefinedProperties",
Line 91:                         "predefinedProperties", "customProperties" }));
Line 92:     }
Line 93: 


--
To view, visit http://gerrit.ovirt.org/9480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42da374a6929eae9be1880b6948d9218627b6c4f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to