Yair Zaslavsky has posted comments on this change. Change subject: core: Rename ad_groups class to AdGroups ......................................................................
Patch Set 3: Hi Sharad, If you go for this change - I would recommend to change the name to one of the following: 1. UsersGroup 2. LdapGroup Remove the "AdXXX" Prefix - this is not just for AD. The plural form is misleading. -- To view, visit http://gerrit.ovirt.org/9835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2429b55981a18cbb8fc9ceaf33d949195d66d8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
