Yair Zaslavsky has posted comments on this change.

Change subject: core: Rename ad_groups class to AdGroups
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdUser.java
Line 30:     private List<String> memberof;
Line 31: 
Line 32:     private Map<String, AdGroups> mGroups;
Line 33: 
Line 34:     public AdUser() {
Please also rename this entity - once again,
You should know better we don't work just with AD ;)
Line 35:         mUserId = Guid.Empty;
Line 36:         mGroups = new HashMap<String, AdGroups>();
Line 37:     }
Line 38: 


--
To view, visit http://gerrit.ovirt.org/9835
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2429b55981a18cbb8fc9ceaf33d949195d66d8c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to