Mike Kolesnik has posted comments on this change.

Change subject: engine: Adding  VmGuestInfoInterface
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/dbscripts/upgrade/03_02_0050_add_vm_guest_agent_interfaces_table.sql
Line 1: CREATE OR REPLACE FUNCTION 
__tmp_03_02_0050_add_vm_guest_agent_interfaces_table()
Please remove unnecessary re-entry code as it was decided long ago that db 
scripts are not re-entrant
Line 2: RETURNS void
Line 3: AS $function$
Line 4: BEGIN
Line 5:    IF NOT EXISTS (SELECT * FROM information_schema.tables WHERE 
table_name ILIKE 'vm_guest_agent_interfaces') THEN


--
To view, visit http://gerrit.ovirt.org/10098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d25018f94c2b4d29c01be85a222460335603569
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to