Mike Kolesnik has posted comments on this change.
Change subject: engine: Adding VmGuestInfoInterface
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java
Line 92: }
Line 93: if (obj == null) {
Line 94: return false;
Line 95: }
Line 96: if (getClass() != obj.getClass()) {
instanceof would be more suitable
Line 97: return false;
Line 98: }
Line 99: VmGuestAgentInterface other = (VmGuestAgentInterface) obj;
Line 100: if (getInterfaceName() == null) {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java
Line 61: }
Line 62:
Line 63: private List<String> getListOfIpAddresses(String
ipAddressesAsString) {
Line 64: if (ipAddressesAsString == null) {
Line 65: return Collections.emptyList();
Why not return null?
Line 66: }
Line 67: return
Arrays.asList(StringUtils.split(ipAddressesAsString,DELIMITER));
Line 68: }
Line 69: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDao.java
Line 16: * @param vmId
Line 17: * the VM's ID
Line 18: * @return the list of VmGuestAgentInterfaces
Line 19: */
Line 20: public List<VmGuestAgentInterface> getAllForVm(Guid vmId);
public modifier on the methods is redundant and could be removed
Line 21:
Line 22: /**
Line 23: * Removes all the VmGuestAgentInterfaces of the given VM
Line 24: * @param vmId
--
To view, visit http://gerrit.ovirt.org/10098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d25018f94c2b4d29c01be85a222460335603569
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
