Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add "Link State" to VM Interface dialog.
......................................................................
Patch Set 31: Looks good to me, but someone else must approve
(4 inline comments)
minor comments
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 751: @DefaultStringValue("Unplugged")
Line 752: String unpluggedNetworkInteface();
Line 753:
Line 754: @DefaultStringValue("Link State")
Line 755: String linkStateNetworkInteface();
twice?
Line 756:
Line 757: @DefaultStringValue("Up")
Line 758: String linkedNetworkInteface();
Line 759:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java
Line 42: } else if (object instanceof PairQueryable && ((PairQueryable)
object).getFirst() instanceof VmNetworkInterface) {
Line 43: vnic = ((PairQueryable<VmNetworkInterface, VM>)
object).getFirst();
Line 44: }
Line 45:
Line 46: String tooltip = ""; //$NON-NLS-1$
use string builder/buffer... don't remember how it called in java/.NET :)
Line 47: if (vnic.isActive()) {
Line 48: tooltip =
Line 49:
tooltip.concat(templates.cardStatus(constants.pluggedNetworkInteface()).asString());
Line 50: } else {
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
Line 6:
Line 7: <ui:with field='constants'
type='org.ovirt.engine.ui.common.CommonApplicationConstants' />
Line 8:
Line 9: <ui:style
type="org.ovirt.engine.ui.common.widget.uicommon.popup.networkinterface.NetworkInterfacePopupWidget.Style">
Line 10:
TWS all over the file
Line 11: @external .gwt-CheckBox;
Line 12:
Line 13: .macExample {
Line 14: color: gray;
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1614: // Vnic
Line 1615: @DefaultStringValue("Hot Plug is not supported on the current
Cluster version")
Line 1616: String hotPlugNotSupported();
Line 1617:
Line 1618: @DefaultStringValue("In order to change 'Type' please Unplug and
then Plug again")
Unplug and then Plug again = Replug?
Line 1619: String hotTypeUpdateNotPossible();
Line 1620:
Line 1621: @DefaultStringValue("In order to change 'MAC' please Unplug and
then Plug again")
Line 1622: String hotMacUpdateNotPossible();
--
To view, visit http://gerrit.ovirt.org/9449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65601980469d5215e2884bf43be7f10884c4386f
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
