Alona Kaplan has posted comments on this change.

Change subject: webadmin: Add "Link State" to VM Interface dialog.
......................................................................


Patch Set 31: (4 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java
Line 81:     }
Line 82: 
Line 83:     @Override
Line 84:     protected void onPlugChange() {
Line 85:         super.onPlugChange();
if (vmIsUp){
  the remaining code
}
Line 86:         Boolean plug = (Boolean) getPlugged().getEntity();
Line 87: 
Line 88:         if (plug) {
Line 89:             getNicType().getChangeProhibitionReasons()


Line 155: 
Line 156:         boolean isPlugged = (Boolean) getPlugged().getEntity();
Line 157:         boolean isPortMirroring = (Boolean) 
getPortMirroring().getEntity();
Line 158: 
Line 159:         if (hotUpdateSupported) {
&& vmIsUp
Line 160:             if (isPlugged && isPortMirroring) {
Line 161:                 getLinked().getChangeProhibitionReasons()
Line 162:                         .add(ConstantsManager.getInstance()
Line 163:                                 .getConstants()


Line 177: 
Line 178:         boolean isPlugged = (Boolean) getPlugged().getEntity();
Line 179:         boolean isPortMirroring = (Boolean) 
getPortMirroring().getEntity();
Line 180: 
Line 181:         if (hotUpdateSupported) {
&& vmIsUp
Line 182:             if (isPlugged && isPortMirroring) {
Line 183:                 getNetwork().getChangeProhibitionReasons()
Line 184:                         .add(ConstantsManager.getInstance()
Line 185:                                 .getConstants()


Line 186:                                 
.hotNetworkUpdateNotSupportedWithPortMirroring());
Line 187:                 getNetwork().setIsChangable(false);
Line 188:                 return;
Line 189:             }
Line 190:         }else if (isPlugged){
&& vmIsUp
Line 191:                 
getNetwork().getChangeProhibitionReasons().add(ConstantsManager.getInstance()
Line 192:                         .getConstants()
Line 193:                         .hotNetworkUpdateNotSupported());
Line 194:                 getNetwork().setIsChangable(false);


--
To view, visit http://gerrit.ovirt.org/9449
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65601980469d5215e2884bf43be7f10884c4386f
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to