Yair Zaslavsky has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks good.
+2 on engine-side.
See minor comment.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
Line 3: /**
Line 4: * Config Class
Line 5: */
Line 6: public final class Config {
Line 7: public static final String DefaultConfigurationVersion = "general";
Then why keep this one here?
Line 8:
Line 9: private static IConfigUtilsInterface _configUtils;
Line 10:
Line 11: public static IConfigUtilsInterface getConfigUtils() {
--
To view, visit http://gerrit.ovirt.org/10263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
