Gilad Chaplik has posted comments on this change.
Change subject: common: remove Config dependency from front-end.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
Line 3: /**
Line 4: * Config Class
Line 5: */
Line 6: public final class Config {
Line 7: public static final String DefaultConfigurationVersion = "general";
fyi, when you remove a class that you don't want the GWT to use, check
common.gwt.xml, there we specify which classes are being translated.
checked it, and config.java isn't there (the entire config lib is marked)
Line 8:
Line 9: private static IConfigUtilsInterface _configUtils;
Line 10:
Line 11: public static IConfigUtilsInterface getConfigUtils() {
....................................................
Commit Message
Line 3: AuthorDate: 2012-12-19 23:57:22 +0200
Line 4: Commit: Alon Bar-Lev <[email protected]>
Line 5: CommitDate: 2012-12-20 01:54:58 +0200
Line 6:
Line 7: common: remove Config dependency from front-end.
not sure what is 'common:', consider changing to 'engine:'
Line 8:
Line 9: The only use of class org.ovirt.engine.core.common.config.Config is to
Line 10: get the default configuration version.
Line 11:
--
To view, visit http://gerrit.ovirt.org/10263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
