Gilad Chaplik has posted comments on this change. Change subject: common: remove Config dependency from front-end. ......................................................................
Patch Set 2: > I don't understand, is the Config object is called at front-end side, or that > after deserialization all calls are skipped? Config translates to JS, so Config' in client side. > If it called, we get only the values of ConfigValues's default, what happens > if there is a conflict with the actual config? IMHO, there is a bit of a problem there, general is hard-coded, yet can be written with a typo in the db table (consider having a general column?). > I don't see any object implementing the IConfigUtilsInterface at front-end > side... so I don't understand. the frontend probably use the word "general" in the entire config section :))) >> do you want me to write a dependent ui patch that gets 'general' from config >> values (cached in the ui)? > This will be nice! So we be able to drop one more common class... np, do you want "general" to be a configurable value in db (error prone), or remain hard coded? -- To view, visit http://gerrit.ovirt.org/10263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
