Liron Aravot has posted comments on this change.

Change subject: core: ClassCastException when attempting to get storage domain 
of disk
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 249: 
Line 250:     /**
Line 251:      * @return The ID of the storage domain where the VM's disks 
reside.
Line 252:      */
Line 253:     private Guid getDisksStorageDomainId() {
We are getting to this method from AuditLogDirector which has a general 
implementation and not lun/image specific one. this method is overriden in 
AddDiskCommand, therefore i added this if condition.
Line 254:         Disk disk = getVm().getDiskMap().values().iterator().next();
Line 255:         if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
Line 256:             return ((DiskImage) disk).getstorage_ids().get(0);
Line 257:         } else {


--
To view, visit http://gerrit.ovirt.org/10289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to