Liron Aravot has uploaded a new change for review. Change subject: core: ClassCastException when attempting to get storage domain of disk ......................................................................
core: ClassCastException when attempting to get storage domain of disk When a VM has disks, there is an attempt to get the storage domain id from the first vm disk - if the disk is LUN there is a ClassCastException. Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Bug-Url: https://bugzilla.redhat.com/876109 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/10289/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java index 4c09539..83d3252 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java @@ -251,7 +251,12 @@ * @return The ID of the storage domain where the VM's disks reside. */ private Guid getDisksStorageDomainId() { - return ((DiskImage) getVm().getDiskMap().values().iterator().next()).getstorage_ids().get(0); + Disk disk = getVm().getDiskMap().values().iterator().next(); + if (disk.getDiskStorageType() == DiskStorageType.IMAGE) { + return ((DiskImage) disk).getstorage_ids().get(0); + } else { + return Guid.Empty; + } } @Override -- To view, visit http://gerrit.ovirt.org/10289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
