Omer Frenkel has posted comments on this change.
Change subject: Adding hardware information to vds object
......................................................................
Patch Set 20: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetHardwareInfoVDSCommand.java
Line 3: import
org.ovirt.engine.core.common.vdscommands.VdsIdAndVdsVDSCommandParametersBase;
Line 4: import org.ovirt.engine.core.utils.log.Logged;
Line 5: import org.ovirt.engine.core.utils.log.Logged.LogLevel;
Line 6:
Line 7: @Logged(executionLevel = LogLevel.DEBUG)
i don't mind too much, but why this logged in debug?
Line 8: public class GetHardwareInfoVDSCommand<P extends
VdsIdAndVdsVDSCommandParametersBase> extends InfoVdsBrokerCommand<P> {
Line 9: public GetHardwareInfoVDSCommand(P parameters) {
Line 10: super(parameters, parameters.getVds());
Line 11: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 522: &&
handleNetworkException((VDSNetworkException)ret.getExceptionObject(), vds)) {
Line 523: UpdateDynamicData(vds.getDynamicData());
Line 524: UpdateStatisticsData(vds.getStatisticsData());
Line 525: }
Line 526: throw ret.getExceptionObject();
i thought we don't want to give special treatment if this fails, why doing it
for network error?
(it's ok to have it, but i find it strange to have special case for it here)
Line 527: }
Line 528: else if (!ret.getSucceeded()) {
Line 529: AuditLogableBase logable = new AuditLogableBase();
Line 530: AuditLogDirector.log(logable,
AuditLogType.VDS_FAILED_TO_GET_HOST_HARDWARE_INFO);
Line 531: }
Line 532: }
Line 533:
Line 534: VDSStatus returnStatus = vds.getstatus();
Line 535: if (!isSetNonOperational) {
the refactoring done to isSetNonOperational is useless, this if is not needed
Line 536: isSetNonOperational =
CollectVdsNetworkDataVDSCommand.persistAndEnforceNetworkCompliance(vds);
Line 537: if (isSetNonOperational) {
Line 538: setIsSetNonOperationalExecuted(true);
Line 539: }
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
