Yair Zaslavsky has posted comments on this change.
Change subject: Adding hardware information to vds object
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 520: if (!ret.getSucceeded() && ret.getExceptionObject()
!= null) {
Line 521: if (ret.getExceptionObject() instanceof
VDSNetworkException
Line 522: &&
handleNetworkException((VDSNetworkException)ret.getExceptionObject(), vds)) {
Line 523: UpdateDynamicData(vds.getDynamicData());
Line 524: UpdateStatisticsData(vds.getStatisticsData());
please look if you really fill info in VdsStatistics in this call.
Line 525: }
Line 526: throw ret.getExceptionObject();
Line 527: }
Line 528: else if (!ret.getSucceeded()) {
Line 525: }
Line 526: throw ret.getExceptionObject();
Line 527: }
Line 528: else if (!ret.getSucceeded()) {
Line 529: AuditLogableBase logable = new AuditLogableBase();
you need to pass vdsId in the CTOR
Line 530: AuditLogDirector.log(logable,
AuditLogType.VDS_FAILED_TO_GET_HOST_HARDWARE_INFO);
Line 531: }
Line 532: }
Line 533:
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
