Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
......................................................................
Patch Set 2: (5 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2012-12-31 13:59:43 +0200
Line 6:
Line 7: webadmin: Add no-quota notification and quota buttons
Line 8:
Line 9: Sub-tab quota under the main-tab Data Center had no action button (to
button -> buttons.
Line 10: add, edit, copy or remove quota).
Line 11:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Line 9: Sub-tab quota under the main-tab Data Center had no action button (to
Line 10: add, edit, copy or remove quota).
Line 11:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Let's use positive future tense;
When enabling quota in a Data Center, we'd like to notify the user he needs to
define quotas. Otherwise system users may be blocked from running VMs or
creating new disks.
Line 14:
Line 15: A notification was added in cases the user move a Data Center with no
Line 16: defined quotas to enabled mode (Audit/Enforcing).
Line 17:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Line 14:
Line 15: A notification was added in cases the user move a Data Center with no
Line 16: defined quotas to enabled mode (Audit/Enforcing).
This patch will also add such a notification when the data center has no quotas
defined.
Line 17:
Line 18: DataCenterQuotaListModel was changed to inherit QuotaListModel in order
Line 19: to include all CRUD actions.
Line 20:
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 581:
Line 582: @DefaultStringValue("You are about to change the Cluster
Compatibility Version. Are you sure you want to continue?")
Line 583: String youAreAboutChangeClusterCompatibilityVersionMsg();
Line 584:
Line 585: @DefaultStringValue("You are about to enable the Data Center
Quota Enforcement. Since No Quota is defined for this Data Center you could not
run VMs or create new Disk.\n\n" +
Since No Quota is defined => Since no quota allocations are defined
you could not run VMs or create new Disk =>
engine users will not be able run VMs or create new disks. Currently running
VMs will keep running. Use Audit mode in order to get the alerts without
actually blocking the users. Once ready, you can move Quota from Audit to
Enforcing mode to actually block Quota violations.
Line 586: "You can define new Quota instances by selecting the
Quota sub-tab or main-tab and click the add button (This can also be done after
the Data Center Quota Enforcement was enabled).\n\n" +
Line 587: "Are you sure you want to continue?")
Line 588: String youAreAboutChangeDCQuotaEnforcementMsg();
Line 589:
Line 582: @DefaultStringValue("You are about to change the Cluster
Compatibility Version. Are you sure you want to continue?")
Line 583: String youAreAboutChangeClusterCompatibilityVersionMsg();
Line 584:
Line 585: @DefaultStringValue("You are about to enable the Data Center
Quota Enforcement. Since No Quota is defined for this Data Center you could not
run VMs or create new Disk.\n\n" +
Line 586: "You can define new Quota instances by selecting the
Quota sub-tab or main-tab and click the add button (This can also be done after
the Data Center Quota Enforcement was enabled).\n\n" +
=>
In order to define quota allocations, go to quota main tab, or in Data Center
tab choose quota sub-tab. Use the add button in order to define a new quota
allocation. Note that this can be done regardless of Quota state being enabled
or disabled.
Line 587: "Are you sure you want to continue?")
Line 588: String youAreAboutChangeDCQuotaEnforcementMsg();
Line 589:
Line 590: @DefaultStringValue("You are about to disable CPU thread support
for this cluster. Disabling this can affect the ability to run VMs with certain
CPU configurations.\n\n" +
--
To view, visit http://gerrit.ovirt.org/10520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5d360af1329df9f274f9e9651e3c0d9a8053f1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
