ofri masad has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
......................................................................
Patch Set 2: (8 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2012-12-31 13:59:43 +0200
Line 6:
Line 7: webadmin: Add no-quota notification and quota buttons
Line 8:
Line 9: Sub-tab quota under the main-tab Data Center had no action button (to
Done
Line 10: add, edit, copy or remove quota).
Line 11:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Line 9: Sub-tab quota under the main-tab Data Center had no action button (to
Line 10: add, edit, copy or remove quota).
Line 11:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Done
Line 14:
Line 15: A notification was added in cases the user move a Data Center with no
Line 16: defined quotas to enabled mode (Audit/Enforcing).
Line 17:
Line 12: When a Data Center with no defined quotas was moved to enabled mode
Line 13: the user was not notify this may cause blocking of some actions.
Line 14:
Line 15: A notification was added in cases the user move a Data Center with no
Line 16: defined quotas to enabled mode (Audit/Enforcing).
Done
Line 17:
Line 18: DataCenterQuotaListModel was changed to inherit QuotaListModel in order
Line 19: to include all CRUD actions.
Line 20:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
Line 636:
tempVar2.setTitle(ConstantsManager.getInstance().getConstants().cancel());
Line 637: tempVar2.setIsCancel(true);
Line 638: confirmModel.getCommands().add(tempVar2);
Line 639: }
Line 640: else if (((storage_pool)
getSelectedItem()).getQuotaEnforcementType() ==
QuotaEnforcementTypeEnum.DISABLED
Done
Line 641: &&
model.getQuotaEnforceTypeListModel().getSelectedItem() !=
QuotaEnforcementTypeEnum.DISABLED) {
Line 642: promptNoQuotaAvailable(model.getEntity(), this);
Line 643: }
Line 644: else
Line 648: }
Line 649:
Line 650: private void promptNoQuotaAvailable(storage_pool storage_pool,
final ICommandTarget commandTarget) {
Line 651: GetQuotaByStoragePoolIdQueryParameters parameters = new
GetQuotaByStoragePoolIdQueryParameters();
Line 652: parameters.setRefresh(getIsQueryFirstTime());
Done
Line 653: parameters.setStoragePoolId(storage_pool.getId());
Line 654: Frontend.RunQuery(VdcQueryType.GetQuotaByStoragePoolId,
Line 655: parameters,
Line 656: new AsyncQuery(
Line 649:
Line 650: private void promptNoQuotaAvailable(storage_pool storage_pool,
final ICommandTarget commandTarget) {
Line 651: GetQuotaByStoragePoolIdQueryParameters parameters = new
GetQuotaByStoragePoolIdQueryParameters();
Line 652: parameters.setRefresh(getIsQueryFirstTime());
Line 653: parameters.setStoragePoolId(storage_pool.getId());
Done
Line 654: Frontend.RunQuery(VdcQueryType.GetQuotaByStoragePoolId,
Line 655: parameters,
Line 656: new AsyncQuery(
Line 657: quotaListModel,
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 581:
Line 582: @DefaultStringValue("You are about to change the Cluster
Compatibility Version. Are you sure you want to continue?")
Line 583: String youAreAboutChangeClusterCompatibilityVersionMsg();
Line 584:
Line 585: @DefaultStringValue("You are about to enable the Data Center
Quota Enforcement. Since No Quota is defined for this Data Center you could not
run VMs or create new Disk.\n\n" +
Done
Line 586: "You can define new Quota instances by selecting the
Quota sub-tab or main-tab and click the add button (This can also be done after
the Data Center Quota Enforcement was enabled).\n\n" +
Line 587: "Are you sure you want to continue?")
Line 588: String youAreAboutChangeDCQuotaEnforcementMsg();
Line 589:
Line 582: @DefaultStringValue("You are about to change the Cluster
Compatibility Version. Are you sure you want to continue?")
Line 583: String youAreAboutChangeClusterCompatibilityVersionMsg();
Line 584:
Line 585: @DefaultStringValue("You are about to enable the Data Center
Quota Enforcement. Since No Quota is defined for this Data Center you could not
run VMs or create new Disk.\n\n" +
Line 586: "You can define new Quota instances by selecting the
Quota sub-tab or main-tab and click the add button (This can also be done after
the Data Center Quota Enforcement was enabled).\n\n" +
Done
Line 587: "Are you sure you want to continue?")
Line 588: String youAreAboutChangeDCQuotaEnforcementMsg();
Line 589:
Line 590: @DefaultStringValue("You are about to disable CPU thread support
for this cluster. Disabling this can affect the ability to run VMs with certain
CPU configurations.\n\n" +
--
To view, visit http://gerrit.ovirt.org/10520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5d360af1329df9f274f9e9651e3c0d9a8053f1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
