Omer Frenkel has posted comments on this change.
Change subject: core: rerun HA vm that fails during live snapshot
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1734: private void clearVm(VM vm, String exitMessage) {
Line 1735: if (vm.getStatus() != VMStatus.MigratingFrom) {
Line 1736: if (vm.getStatus() != VMStatus.Suspended) {
Line 1737:
ResourceManager.getInstance().InternalSetVmStatus(vm, VMStatus.Down);
Line 1738: vm.setExitStatus(VmExitStatus.Error);
are you sure its always error? why not use status from vdsm?
Line 1739: vm.setExitMessage(exitMessage);
Line 1740: }
Line 1741: AddVmDynamicToList(vm.getDynamicData());
Line 1742: AddVmStatisticsToList(vm.getStatisticsData());
--
To view, visit http://gerrit.ovirt.org/10618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5daeffd1cee106019065c29fb8428a9b9f78a5d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
