Omer Frenkel has posted comments on this change.
Change subject: core: rerun HA vm that fails during live snapshot
......................................................................
Patch Set 6: (3 inline comments)
looks ok, minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 147: }
Line 148:
Line 149: @Override
Line 150: protected void endVmCommand() {
Line 151: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
why did you remove the comment explaining this transaction?
Line 152:
Line 153: @Override
Line 154: public Void runInTransaction() {
Line 155: final boolean taskGroupSucceeded =
getParameters().getTaskGroupSuccess();
Line 176: });
Line 177:
Line 178: // if the VM is HA + it went down during the snapshot
creation process because of an error, run it
Line 179: // (during the snapshot creation process the VM couldn't be
started (rerun))
Line 180: if (getVm().isAutoStartup() && isVmDownUnintentionally() &&
getParameters().getInitialVmStatus() != VMStatus.Down) {
i see there is a check for getVm() != null inside the transaction (previous
code) i guess its there for a reason, so add it here as well
Line 181:
Backend.getInstance().runInternalAction(VdcActionType.RunVm,
Line 182: new RunVmParams(getVmId()),
Line 183: ExecutionHandler.createInternalJobContext());
Line 184: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1733: }
Line 1734:
Line 1735: private void clearVm(VM vm, VmExitStatus exitStatus, String
exitMessage) {
Line 1736: if (vm.getStatus() != VMStatus.MigratingFrom ) {
Line 1737: if (vm.getStatus() != VMStatus.Suspended &&
vm.getStatus() != VMStatus.Down) {
maybe add a comment here?
Line 1738:
ResourceManager.getInstance().InternalSetVmStatus(vm, VMStatus.Down,
exitStatus, exitMessage);
Line 1739: }
Line 1740: AddVmDynamicToList(vm.getDynamicData());
Line 1741: AddVmStatisticsToList(vm.getStatisticsData());
--
To view, visit http://gerrit.ovirt.org/10618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5daeffd1cee106019065c29fb8428a9b9f78a5d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
