Yair Zaslavsky has posted comments on this change.
Change subject: core: avoid reconstructs based on stale data
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Please fix the first comment,
One again - looks good infra-wise, and as far as I understand the flow.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 452: return ResourceManager.getInstance()
Line 453: .getEventListener()
Line 454:
.masterDomainNotOperational(masterDomainId, storagePool.getId());
Line 455: } else {
Line 456: return new EventResult(true,
EventType.RECONSTRUCT);
Done
Line 457: }
Line 458: }
Line 459: });
Line 460: throw new IRSNoMasterDomainException(exceptionMessage);
--
To view, visit http://gerrit.ovirt.org/10764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2dd69b1766ab92be7428c8973590709a52d5d48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
