Michael Kublin has posted comments on this change.

Change subject: core: avoid reconstructs based on stale data
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Solution is wrong. You should fix a reconstruct command - don't do reconstruct 
when everything is ok, especially when you have a canDoAction at Reconstruct 
command.
Also these solution will not solve a bug provided in description, in the logs 
we can see a triggering of 3 reconstruct sententiously, so change description 
and move code to canDoAction of ReconstructCommand

--
To view, visit http://gerrit.ovirt.org/10764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2dd69b1766ab92be7428c8973590709a52d5d48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to