Arik Hadas has posted comments on this change.
Change subject: core: Move status check methods from VM to VMStatus
......................................................................
Patch Set 1:
since 3 people didn't like the names of the methods, I don't mind to change
them but I think the proposed names aren't intuitive because running() for
example may be interpreted as the status is running and there is definitely not
the case.. maybe isVmRunning will be better, although I still think that
basically what this method express is "if a VM had this status, it would be
running"..
about using these methods, I thought of other usage - to add methods to VM that
just delegate to its status, something like:
public boolean isRunning() {
return getStatus().isStatusOfRunningVm();
}
and most of the time those methods will be called when you have vm instance.
the VMStatus's method will be called only if you have only the status instance.
what do you think?
--
To view, visit http://gerrit.ovirt.org/10795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
